allow converting from/to PoseWithCovarianceStamped #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adityapande-1995 here is the PR you proposed :) |
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com> fix typo Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
4f0b3ee to
f4da30a
Compare
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
adityapande-1995
requested changes
Apr 24, 2023
There was a problem hiding this comment.
Thanks for adding this ! Could you update the README file to reflect this change ? https://github.com/gazebosim/ros_gz/blob/ros2/ros_gz_bridge/README.md
Signed-off-by: Alaa El Jawad <ejalaa12@gmail.com>
Sure ! Btw, I went ahead and fixed the Table header alignement from |
adityapande-1995
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Relates to PR #374.
Summary
ros_gz_bridge allows converting gz.msgs.PoseWithCovariance <-> geometry_msgs.msg.PoseWithCovariance.
However the gz.msgs.PoseWithCovariance also contains a header and stamp. So it could be converted to a geometry_msgs.msg.PoseWithCovarianceStamped.
This PR implements that conversion. It is now possible to convert either to/from:
geometry_msgs.msg.PoseWithCovariance
geometry_msgs.msg.PoseWithCovarianceStamped.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.