Introduce WrenchStamped into bridge #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Nov 7, 2022
ahcorde
requested changes
Nov 7, 2022
There was a problem hiding this comment.
tests are also failing (uncrustify at least)
https://github.com/gazebosim/ros_gz/actions/runs/3395417704/jobs/5649418290
c063769 to
2546bbd
Compare
Signed-off-by: Lovro <lovro.ivanov@gmail.com>
Signed-off-by: Lovro <lovro.ivanov@gmail.com>
Signed-off-by: Lovro <lovro.ivanov@gmail.com>
c14883b to
aea58d6
Compare
|
@ahcorde friendly ping for a review. I improved |
ahcorde
approved these changes
Feb 8, 2023
|
I will create a forward port soon. Thank you for your contribution @livanov93 |
|
When will this change be forwarded to the ubuntu repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Summary
Introduces conversion between
geometry_msgs::msg::WrenchStampedandignition_msgs.msg.Wrench.Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.