Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert gz.msgs.Wrench to geometry_msgs/WrenchStamped instead of geometry_msgs/Wrench #359

Closed
xibeisiber opened this issue Feb 3, 2023 · 3 comments
Closed

convert gz.msgs.Wrench to geometry_msgs/WrenchStamped instead of geometry_msgs/Wrench #359

xibeisiber opened this issue Feb 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@xibeisiber
Copy link

xibeisiber commented Feb 3, 2023 •
edited
Loading

Desired behavior

The timestamp and frame information contained in gz.msgs.Wrench is dropped when converting to geometry_msgs/Wrench.
Maybe use geometry_msgs/WrenchStamped?

Implementation suggestion

convert gz.msgs.Wrench to geometry_msgs/WrenchStamped instead of geometry_msgs/Wrench
@xibeisiber xibeisiber added the enhancement New feature or request label Feb 3, 2023
@azeey azeey self-assigned this Feb 6, 2023
@azeey
Copy link
Contributor

azeey commented Feb 6, 2023

I think we can add geometry_msgs/WrenchStamped as an additional output type for gz.msgs.Wrench. Would you be able to create a PR?

@azeey azeey added the help wanted Extra attention is needed label Feb 6, 2023
@azeey azeey removed their assignment Feb 6, 2023
@azeey
Copy link
Contributor

azeey commented Feb 6, 2023

Actually, looks like there's already a PR for that #327

@azeey azeey removed the help wanted Extra attention is needed label Feb 6, 2023
@azeey
Copy link
Contributor

azeey commented Feb 9, 2023

#327 has been merged.

@azeey azeey closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azeey @xibeisiber