3 to 4 #933
Merged
3 to 4 #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com> Co-authored-by: RafiAbdullah <rafi@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Marcos Wagner <wagnermarcos@ekumenlabs.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com> Co-authored-by: Franco Cipollone <franco.c@ekumenlabs.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: addy1997 <adwaitnaik2@gmail.com> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com> Removed changes to diff-drive command when backporting to ign-gazebo3 Signed-off-by: Louise Poubel <louise@openrobotics.org>
Extend test to have two logical cameras observing the same box. Signed-off-by: Jaldert Rombouts <jaldert@vicarious.com>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Added world exporter Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Fixed CMake Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Changes based on review Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar> * Added example world Signed-off-by: Nate Koenig <nate@openrobotics.org> * bump required ign-common version Signed-off-by: Louise Poubel <louise@openrobotics.org> * PR updates Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update documentation to have simulation self terminate Signed-off-by: Nate Koenig <nate@openrobotics.org> * Rename world_export to collada_world_exporter Signed-off-by: Nate Koenig <nate@openrobotics.org> * Finish world exporter renaming Signed-off-by: Nate Koenig <nate@openrobotics.org> * Revert change Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added a tutorial Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update transform Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added message Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added a test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added more shapes Signed-off-by: Nate Koenig <nate@openrobotics.org> * Cleanup in two locations Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix build Signed-off-by: Nate Koenig <nate@openrobotics.org> * Apply scale, and fix codecheck Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
…ts. (#629) Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
7 tasks
5efdfb0 to
02ee7c3
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #933 +/- ##
===============================================
+ Coverage 65.98% 66.26% +0.28%
===============================================
Files 239 240 +1
Lines 17686 17872 +186
===============================================
+ Hits 11670 11843 +173
- Misses 6016 6029 +13
Continue to review full report at Codecov.
|
|
It looks like macOS hasn't picked up on the new GUI release: https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-homebrew-amd64/6141/consoleFull#18361520546ea37b8d-a6d4-40ae-8431-d90c018842af However, the bottle has been built (I think): osrf/homebrew-simulation#1541 Is there a way to verify that macOS has picked up the new GUI release? |
02ee7c3 to
d76a6c2
Compare
|
Now that the |
|
macOS is building now. The INTEGRATION_user_commands test failed again, but it has failed for the past 19 builds, so I don't think it's related to this PR. I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gazebo3toign-gazebo4Branch comparison: ign-gazebo4...ign-gazebo3
I had to resolve a few merge conflicts. I believe that we will also need an
ign-gui4release in order to support #904, which is part of this forward-port.Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)