Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding PBR materials #575

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Fix finding PBR materials #575

merged 1 commit into from
Jan 21, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jan 21, 2021

While loading https://app.ignitionrobotics.org/OpenRobotics/fuel/models/DronePlatformX1 I would see the following errors:

[Err] [SystemPaths.cc:444] Could not resolve file [./materials/textures/DronePlatformX1_Roughness.jpg]
[Err] [SceneManager.cc:465] Unable to find file [./materials/textures/DronePlatformX1_Roughness.jpg]
[Err] [SystemPaths.cc:444] Could not resolve file [./materials/textures/DronePlatformX1_Albedo.jpg]
[Err] [SceneManager.cc:498] Unable to find file [./materials/textures/DronePlatformX1_Albedo.jpg]
[Err] [SystemPaths.cc:444] Could not resolve file [./materials/textures/DronePlatformX1_Normal.jpg]
[Err] [SceneManager.cc:509] Unable to find file [./materials/textures/DronePlatformX1_Normal.jpg]

This resolves those errors.

Signed-off-by: Nate Koenig nate@openrobotics.org

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from adlarkin January 21, 2021 00:38
@nkoenig nkoenig requested a review from iche033 as a code owner January 21, 2021 00:38
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 21, 2021
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the error messages for me, but I still am not seeing the platform. For example, here's what I see after running

ign launch competition.ign worldName:=simple_cave_01 circuit:=cave robotName1:=X1 robotConfig1:=X1_SENSOR_CONFIG_1 robotName2:=X2 robotConfig2:=CERBERUS_RMF_SENSOR_CONFIG_1 marsupial1:=X1:X2

(related to osrf/subt#763):
no_platform

@nkoenig
Copy link
Contributor Author

nkoenig commented Jan 21, 2021

This removes the error messages for me, but I still am not seeing the platform. For example, here's what I see after running

ign launch competition.ign worldName:=simple_cave_01 circuit:=cave robotName1:=X1 robotConfig1:=X1_SENSOR_CONFIG_1 robotName2:=X2 robotConfig2:=CERBERUS_RMF_SENSOR_CONFIG_1 marsupial1:=X1:X2

If you are running a source build, could you try updating everything?

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #575 (a560491) into ign-gazebo4 (4dbf229) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #575      +/-   ##
===============================================
- Coverage        77.35%   77.35%   -0.01%     
===============================================
  Files              213      213              
  Lines            11925    11925              
===============================================
- Hits              9225     9224       -1     
- Misses            2700     2701       +1     
Impacted Files Coverage Δ
src/Server.cc 82.80% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dbf229...a560491. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@chapulina chapulina changed the title Fix finding pb materials Fix finding PBR materials Jan 21, 2021
@chapulina chapulina merged commit a9cf78d into ign-gazebo4 Jan 21, 2021
@chapulina chapulina deleted the fix_find_pbr_files branch January 21, 2021 02:36
@chapulina chapulina mentioned this pull request Jan 21, 2021
chapulina pushed a commit that referenced this pull request Jul 23, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
chapulina pushed a commit that referenced this pull request Jul 23, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
chapulina pushed a commit that referenced this pull request Jul 23, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants