Update wireframe visualization to support nested models #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
ahcorde
approved these changes
May 25, 2021
|
@osrf-jenkins retest this please |
…into wireframe_nested_models
|
@osrf-jenkins retest this please |
1 similar comment
|
@osrf-jenkins retest this please |
…into wireframe_nested_models
|
@osrf-jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Atharva Pusalkar atharvapusalkar18@gmail.com
🦟 Bug fix
Summary
Updates the wireframe visualization to support SDFormat 1.8. Related to #823 and #767.
Test it
Test it by running
ign gazebo nested_model.sdfin your workspace. Right-click on an entity and view it as a wireframe.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge