Update collision visualization to support nested models #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
jennuine
reviewed
May 18, 2021
There was a problem hiding this comment.
Thank you for tackling this @atharva-18 and great work so far!
Unfortunately, this does not work for deeply nested models. In the gif, only 2 objects in the scene show collisions but all 5 should be shown when viewing all collisions for M1:
Assuming you are using an Edifice workspace, to run this example:
export IGN_GAZEBO_RESOURCE_PATH=<path to Edifice workspace>/src/ign-gazebo/test/worlds/models
ign gazebo <path to workspace>/src/ign-gazebo/test/worlds/model_nested_include.sdfSigned-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
|
@atharva-18 is this bug also affecting your wireframe PR? |
|
@ahcorde Yes, this bug is present in the wireframe visualization. I'll open a PR addressing it once this one gets approved. |
ahcorde
approved these changes
May 19, 2021
jennuine
reviewed
May 19, 2021
|
Also, I think we should |
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
ahcorde
approved these changes
May 20, 2021
|
@osrf-jenkins retest this please |
…-gazebo into collisions_nested_model
|
@osrf-jenkins retest this please |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Atharva Pusalkar atharvapusalkar18@gmail.com
🦟 Bug fix
Fixes #767
Summary
Updates collision visualization to support SDFormat 1.8.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸