Merge 7 -> 8 #2504
Merged
Merge 7 -> 8 #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolve failing tests Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Cleanup Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Update src/EntityComponentManager.cc Co-authored-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Incorrect else Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Merge 6 -> 7
Adds support for Spacecraft thrusters controlled with a duty cycle signal (such as PWM). --------- Signed-off-by: Pedro Roque <padr@kth.se> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
|
This needs an sdformat14 release. |
7 tasks
sdformat 14.5.0 is out. CI works now |
nkoenig
approved these changes
Aug 12, 2024
azeey
reviewed
Aug 12, 2024
src/SimulationRunner.cc
Outdated
| << worldName << "]." << std::endl; | ||
| return; | ||
| } | ||
| this->worldName = _world.Name(); |
There was a problem hiding this comment.
Should we not keep the AsValidTopic call here?
e14e3d7 to
85254b9
Compare
38acc56 to
d57ac10
Compare
Closed
|
Commented on a change of behavior in #2452. |
Signed-off-by: Ian Chen <ichen@openrobotics.org>
|
merged from gz-sim7 and removed deprecations in 8bb7208 |
azeey
approved these changes
Aug 21, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port gz-sim7 to gz-sim8
Branch comparison: gz-sim8...gz-sim7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)