Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update underwater_vehicles.md #2128

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Update underwater_vehicles.md #2128

merged 2 commits into from
Sep 8, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 8, 2023

🦟 Documentation fix

Fixes gazebosim/gazebo_test_cases#394

Summary

Fixed topic name

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll September 8, 2023 12:58
@ahcorde ahcorde self-assigned this Sep 8, 2023
@ahcorde ahcorde requested a review from mabelzhang as a code owner September 8, 2023 12:58
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2128 (41e918f) into gz-sim8 (923ccee) will decrease coverage by 0.01%.
Report is 4 commits behind head on gz-sim8.
The diff coverage is n/a.

❗ Current head 41e918f differs from pull request most recent head 61e4af5. Consider uploading reports for the commit 61e4af5 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2128      +/-   ##
===========================================
- Coverage    65.45%   65.45%   -0.01%     
===========================================
  Files          323      323              
  Lines        30704    30704              
===========================================
- Hits         20097    20096       -1     
- Misses       10607    10608       +1     

see 1 file with indirect coverage changes

Copy link
Contributor

@Voldivh Voldivh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment from @iche033 , LGTM

Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Copy link
Contributor

@Voldivh Voldivh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahcorde ahcorde merged commit 5fbfcf7 into gz-sim8 Sep 8, 2023
@ahcorde ahcorde deleted the ahcorde-patch-1 branch September 8, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants