Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid service names #2121

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fixed invalid service names #2121

merged 2 commits into from
Sep 7, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 7, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#374

Summary

Fixed invalid service names

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll as a code owner September 7, 2023 14:54
@ahcorde ahcorde self-assigned this Sep 7, 2023
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 7, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2121 (8455cc6) into gz-sim8 (58a0c0b) will decrease coverage by 0.01%.
Report is 1 commits behind head on gz-sim8.
The diff coverage is 62.50%.

❗ Current head 8455cc6 differs from pull request most recent head 57a8be5. Consider uploading reports for the commit 57a8be5 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2121      +/-   ##
===========================================
- Coverage    65.45%   65.45%   -0.01%     
===========================================
  Files          323      323              
  Lines        30699    30704       +5     
===========================================
+ Hits         20094    20096       +2     
- Misses       10605    10608       +3     
Files Changed Coverage Δ
src/SimulationRunner.cc 90.81% <50.00%> (-0.40%) ⬇️
src/systems/user_commands/UserCommands.cc 60.80% <100.00%> (ø)

@ahcorde ahcorde merged commit 491fa23 into gz-sim8 Sep 7, 2023
@ahcorde ahcorde deleted the ahcorde/8/fix_spaces branch September 7, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants