-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some windows warnings (C4244 and C4305) #1874
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1874 +/- ##
===============================================
- Coverage 64.80% 64.78% -0.02%
===============================================
Files 322 322
Lines 26389 26391 +2
===============================================
- Hits 17101 17098 -3
- Misses 9288 9293 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
signoffs don't work correctly when applying code suggestions, so you'll have to follow the instructions here to rebase your commits with signoffs to fix the DCO error. |
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
b1346de
to
5d27b81
Compare
More details: 0a84abe Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@osrf-jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just running through CI one more time.
Homebrew test regressions are known issues reported here: #1867 |
🦟 Bug fix
Fixes part of #1870
Summary
This PR fixes some warnings (C4244 and C4305) happening in ign-gazebo6 windows
Reference build: https://build.osrfoundation.org/job/ign_gazebo-ign-6-win/166/
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.