Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towards Green CI #1771

Merged
merged 24 commits into from
Nov 2, 2022
Merged

Towards Green CI #1771

merged 24 commits into from
Nov 2, 2022

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

Fix things that are currently known-bad in CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
Fix compiler warnings
16e5408 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Fix broken test from name change
38d374e 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Fix breadcrumbs test
c5023bb 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 27, 2022
@mjcarroll mjcarroll self-assigned this Oct 27, 2022
mjcarroll and others added 3 commits October 27, 2022 11:04
@mjcarroll
Lint
22c42e3 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
More renaming fixes
82c8fb5 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Test cleanup
0797c0c 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@codecov
Copy link

codecov bot commented Oct 27, 2022 •
edited
Loading

Codecov Report

Merging #1771 (4112b04) into gz-sim7 (6a8594b) will decrease coverage by 0.34%.
The diff coverage is 73.21%.

@@             Coverage Diff             @@
##           gz-sim7    #1771      +/-   ##
===========================================
- Coverage    64.16%   63.81%   -0.35%     
===========================================
  Files          335      336       +1     
  Lines        26508    27170     +662     
===========================================
+ Hits         17008    17339     +331     
- Misses        9500     9831     +331
Impacted Files Coverage Δ
src/ServerPrivate.cc 82.96% <0.00%> (ø)
src/systems/track_controller/TrackController.cc 46.80% <ø> (+0.19%) ⬆️
src/SystemLoader.cc 59.50% <44.44%> (+1.54%) ⬆️
src/systems/acoustic_comms/AcousticComms.cc 93.22% <93.22%> (ø)
src/Server.cc 89.93% <100.00%> (ø)
src/SimulationRunner.cc 92.27% <100.00%> (ø)
src/systems/rf_comms/RFComms.cc 89.76% <100.00%> (+0.16%) ⬆️
src/Util.cc 93.08% <0.00%> (-0.63%) ⬇️
src/rendering/SceneManager.cc 33.63% <0.00%> (+5.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Nate Koenig and others added 11 commits October 27, 2022 13:34
Fix flaky test
ad60db8 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Fix more tests
05cfab8 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Added missing file
eeca767 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
fix gz_TEST
6acac79 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@mjcarroll
Fix python test
d7f2402 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Fix fuel_cached_server
f6035f4 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Fix odometry test
df7177b 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@mjcarroll
Windows warnings
4d05028 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Merge remote-tracking branch 'origin/mjcarroll/green_build' into mjca…
e4d941c 
…rroll/green_build
lint
bd47006 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Fix optical tacticle plugin and test
0a84abe 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@mjcarroll
Copy link
Contributor Author

Getting much closer here!

On Windows we are down to 80 compiler warnings (in various places) and the "HydronamicsTest.VelcoityTestInOil" which has been failing for 70 builds now.

On Ubuntu we are down to UNIT_Gui_clean_exit_TEST which segfaults...

@nkoenig
Copy link
Contributor

nkoenig commented Oct 28, 2022

I'm trying to reproduce the UNIT_Gui_clean_exit_TEST problem locally.

@mjcarroll
Copy link
Contributor Author

I'm thinking that we disable and ticket this HydronamicsTest, I don't see any evidence that it ever worked.

@nkoenig
Copy link
Contributor

nkoenig commented Oct 28, 2022

I'm good with that plan

@mjcarroll
Bump gitignore
c7c1016 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Disable failing Windows test
17238a6 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Copy link
Contributor Author

I'm good with that plan

I marked it as disabled on Windows. We should be down to the GUI clean exit test and some Windows warnings.

@mjcarroll
Windows warnings
827e8f9 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll mentioned this pull request Oct 31, 2022
Merged
8 tasks
@mjcarroll
Copy link
Contributor Author

Some of these warnings are coming from fuel_tools, addressing those separately here: gazebosim/gz-fuel-tools#308

mjcarroll and others added 3 commits October 31, 2022 13:54
@mjcarroll
Lint
a2cefba 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
fix server test
f0865c0 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Merge branch 'mjcarroll/green_build' of github.com:ignitionrobotics/i…
2904fc4 
…gn-gazebo into mjcarroll/green_build
@mjcarroll
Copy link
Contributor Author

Remaining Windows warnings are coming from physics. Addressed via: gazebosim/gz-physics#446

@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

Fix type cast
4112b04 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@mjcarroll mjcarroll requested a review from nkoenig November 2, 2022 13:13
@nkoenig
Copy link
Contributor

nkoenig commented Nov 2, 2022

Window's warnings are gone. I'm unable to solve the server and gui tests easily, so I'll save those for another PR.

@mjcarroll mjcarroll merged commit 02b3f59 into gz-sim7 Nov 2, 2022
@mjcarroll mjcarroll deleted the mjcarroll/green_build branch November 2, 2022 15:39
@mjcarroll mjcarroll mentioned this pull request Nov 3, 2022
Merged
9 tasks
Crola1702 added a commit that referenced this pull request Feb 2, 2023
@Crola1702
Aplly test fix done in gz-sim7 (gz-sim #1771)
0a99678 
More details: 0a84abe

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Crola1702 added a commit that referenced this pull request Feb 3, 2023
@Crola1702 @azeey
Fix some windows warnings (C4244 and C4305) (#1874)
0960498 
Fixes part of #1870

This PR fixes some warnings (C4244 and C4305) happening in ign-gazebo6 windows
Reference build: https://build.osrfoundation.org/job/ign_gazebo-ign-6-win/166/

* Fix warning C4244

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Fix warning C4305

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Fix line lenght linter error

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Fix linter issues again

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Update src/systems/optical_tactile_plugin/OpticalTactilePlugin.cc

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Apply PR suggestions

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Fix bracket position

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

* Aplly test fix done in gz-sim7 (gz-sim #1771)

More details: 0a84abe

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>

---------

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
@scpeters scpeters mentioned this pull request Feb 8, 2023
Merged
scpeters added a commit that referenced this pull request Feb 10, 2023
@scpeters
Backport portion of #1771 to fix command-line test
34aadc8 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Feb 11, 2023
@scpeters
Backport portion of #1771 to fix command-line test
940e5f3 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

Assignees

@mjcarroll mjcarroll

Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @nkoenig