Fix tutorial for blender_sdf_exporter
#1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
2 tasks
mabelzhang
reviewed
Oct 5, 2022
| @@ -22,7 +22,7 @@ def export_sdf(prefix_path): | |||
| meshes_folder_prefix = 'meshes/' | |||
|
|
|||
| # Exports the dae file and its associated textures | |||
| bpy.ops.wm.collada_export(filepath=prefix_path+meshes_folder_prefix+dae_filename, check_existing=False, filter_blender=False, filter_image=False, filter_movie=False, filter_python=False, filter_font=False, filter_sound=False, filter_text=False, filter_btx=False, filter_collada=True, filter_folder=True, filemode=8) | |||
| bpy.ops.wm.collada_export(filepath=os.path.join(prefix_path, meshes_folder_prefix, dae_filename), check_existing=False, filter_blender=False, filter_image=False, filter_movie=False, filter_python=False, filter_font=False, filter_sound=False, filter_text=False, filter_btx=False, filter_collada=True, filter_folder=True, filemode=8) | |||
There was a problem hiding this comment.
Would be good to break this long line into 80-character lines.
There was a problem hiding this comment.
I formatted everything via the last commit e17968b using isort and black with default settings.
Originally, I did not want to do this because of the number of changes this generates (although this commit fixes a lot of things like quote and indentation inconsistency). Please, let me know if I should revert it and fix only the line lengths.
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1718 +/- ##
===========================================
+ Coverage 63.93% 64.22% +0.29%
===========================================
Files 334 336 +2
Lines 26333 26567 +234
===========================================
+ Hits 16836 17063 +227
- Misses 9497 9504 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nkoenig
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
I encountered 2 issues when trying the tutorial.
.dae) would get exported correctly under./meshes/model.dae. However, SDF file refer to./model.daeas a relative URI for the mesh, which prevented Gazebo from finding it (assuming that only the parent directory of the model is part ofGZ_SIM_RESOURCE_PATH). Corrected the path.Tested both with Blender 2.82 and 3.2
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.