Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting heightmap position through sdf #1054

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 25, 2021

🦟 Bug fix

Setting the heightmap sdf element has no effect. This PR reads the value from SDF DOM and passes it to ign-rendering so we can change the heightmap position offset.

Test by downloading a heightmap model from fuel, e.g.
https://app.ignitionrobotics.org/chapulina/fuel/models/Heightmap%20Bowl

edit the model.sdf in the fuel cache and set the values to anything other than 0 0 0 to change its position

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 25, 2021
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #1054 (dffaa74) into main (f4d47b5) will increase coverage by 0.30%.
The diff coverage is 5.88%.

❗ Current head dffaa74 differs from pull request most recent head 35eb8da. Consider uploading reports for the commit 35eb8da to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   63.71%   64.01%   +0.30%     
==========================================
  Files         257      255       -2     
  Lines       20064    19917     -147     
==========================================
- Hits        12783    12750      -33     
+ Misses       7281     7167     -114     
Impacted Files Coverage Δ
...ins/entity_context_menu/EntityContextMenuPlugin.cc 41.17% <0.00%> (ø)
src/gui/plugins/select_entities/SelectEntities.cc 10.04% <0.00%> (ø)
src/gui/plugins/spawn/Spawn.cc 10.25% <0.00%> (ø)
.../gui/plugins/transform_control/TransformControl.cc 6.97% <0.00%> (ø)
...lization_capabilities/VisualizationCapabilities.cc 7.96% <0.00%> (ø)
src/rendering/SceneManager.cc 28.74% <0.00%> (-0.03%) ⬇️
src/ServerConfig.cc 90.33% <100.00%> (ø)
src/gui/Gui.cc 64.34% <100.00%> (ø)
src/EntityComponentManager.cc 84.95% <0.00%> (-0.15%) ⬇️
src/gui/plugins/view_angle/ViewAngle.cc
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b286a57...35eb8da. Read the comment docs.

@chapulina chapulina merged commit 66c1efd into main Sep 27, 2021
@chapulina chapulina deleted the heightmap_pos branch September 27, 2021 16:40
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants