Support setting heightmap position through sdf #1054
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Setting the heightmap sdf element has no effect. This PR reads the value from SDF DOM and passes it to ign-rendering so we can change the heightmap position offset.
Test by downloading a heightmap model from fuel, e.g.
https://app.ignitionrobotics.org/chapulina/fuel/models/Heightmap%20Bowl
edit the model.sdf in the fuel cache and set the values to anything other than 0 0 0 to change its position
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge