Skip to content

Commit

Permalink
Fix QML warnings regarding binding loops (#1829)
Browse files Browse the repository at this point in the history
In aboutDialog (line 178), the binding loop was created because the height of aboutDialog wasn't set. It was dependent on the height of its child (aboutMessage). But aboutMessage had anchor.fill : parent set which binds its height to the height of its parent.

Similar reasoning applies to fileSaveFailure.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
  • Loading branch information
azeey authored Dec 5, 2022
1 parent ebbe181 commit 3f7218d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/gui/resources/GazeboDrawer.qml
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ Rectangle {
focus: true
parent: ApplicationWindow.overlay
width: parent.width / 3 > 500 ? 500 : parent.width / 3
height: 300
x: (parent.width - width) / 2
y: (parent.height - height) / 2
closePolicy: Popup.CloseOnEscape
Expand Down Expand Up @@ -292,6 +293,7 @@ Rectangle {
modal: true
focus: true
parent: ApplicationWindow.overlay
width: messageText.implicitWidth
x: (parent.width - width) / 2
y: (parent.height - height) / 2
closePolicy: Popup.CloseOnEscape
Expand Down

0 comments on commit 3f7218d

Please sign in to comment.