Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rendering dep to 8 #286

Merged
merged 3 commits into from
Dec 10, 2022
Merged

Bump rendering dep to 8 #286

merged 3 commits into from
Dec 10, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 14, 2022

🎉 New feature

Summary

Bump main to depend on rendering8

gazebo-tooling/release-tools#853

Related PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 marked this pull request as draft November 14, 2022 23:13
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Dec 9, 2022

@osrf-jenkins run tests please

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #286 (5b86b66) into main (920751a) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b86b66 differs from pull request most recent head a1289bb. Consider uploading reports for the commit a1289bb to get more accurate results

@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files          37       37           
  Lines        4690     4690           
=======================================
  Hits         3370     3370           
  Misses       1320     1320           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 marked this pull request as ready for review December 9, 2022 22:44
@iche033
Copy link
Contributor Author

iche033 commented Dec 9, 2022

This PR is ready. Ubuntu Focal / Jammy, Homebrew, Windows CI builds should all be working

@iche033 iche033 merged commit e3fea07 into main Dec 10, 2022
@iche033 iche033 deleted the rendering8 branch December 10, 2022 01:43
@iche033 iche033 added the 🎵 harmonic Gazebo Harmonic label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants