Remove explicitly-defined copy constructor/operator

[mjcarroll]

Cleans up warnings eg:

/home/mjcarroll/workspaces/ign_garden/src/ign-physics/tpe/lib/src/Shape.cc: In copy constructor ‘ignition::physics::tpelib::CapsuleShape::CapsuleShape(const ignition::physics::tpelib::CapsuleShape&)’:
/home/mjcarroll/workspaces/ign_garden/src/ign-physics/tpe/lib/src/Shape.cc:98:11: warning: implicitly-declared ‘ignition::physics::tpelib::CapsuleShape& ignition::physics::tpelib::CapsuleShape::operator=(const ignition::physics::tpelib::CapsuleShape&)’ is deprecated [-Wdeprecated-copy]
   98 |   *this = _other;
      |           ^~~~~~

Signed-off-by: Michael Carroll michael@openrobotics.org.

[ahcorde]

do we need to tick-tock this methods?

[mjcarroll]

do we need to tick-tock this methods?

The corresponding methods should be created by the compiler in these cases.

Furthermore, I'm not entirely convinced that some of these were doing the right thing. The assignment operator is assuming that the RHS was of the same type, even when that wouldn't have been the same.

[codecov]

Codecov Report

Merging #328 (6608c12) into main (f198a7b) will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   75.73%   76.07%   +0.33%     
==========================================
  Files         129      129              
  Lines        5762     5726      -36     
==========================================
- Hits         4364     4356       -8     
+ Misses       1398     1370      -28     

Impacted Files	Coverage Δ
tpe/lib/src/Shape.cc	98.18% <ø> (+18.72%)	⬆️
tpe/lib/src/Shape.hh	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f198a7b...6608c12. Read the comment docs.

[mjcarroll]

Not a great sign from codecov, either 😅

+ Misses       1398     1370      -28     

[scpeters]

there are pre-existing failures on main. I'll merge this now since it is an improvement