1 ➡️ 2 #102
Merged
1 ➡️ 2 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtsim, so slip compliance can be adjusted dynamically (needed by WheelSlipPlugin)
…l be easier to test the Set functions
…rtsim, so slip compliance can be adjusted dynamically (needed by WheelSlipPlugin)
…l be easier to test the Set functions
…tics/ign-physics into set_slip_compliance Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
…tics/ign-physics into set_slip_compliance Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Set slip compliance Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Merged
Codecov Report
@@ Coverage Diff @@
## ign-physics2 #102 +/- ##
================================================
- Coverage 83.43% 83.25% -0.18%
================================================
Files 106 106
Lines 3900 3948 +48
================================================
+ Hits 3254 3287 +33
- Misses 646 661 +15
Continue to review full report at Codecov.
|
|
I wish we had rebased and squashed #56 before merging it |
|
the Ubuntu Focal build is failing; I think we need a dartsim deb with gazebo-forks/dart#12 cc @j-rivero |
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
The Focal build is failing because it's using the upstream version of DART. 6255c27 should fix it. |
azeey
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the only PRs being migrated are #56 and #101.