Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing for 1.9.0 release #101

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Preparing for 1.9.0 release #101

merged 3 commits into from
Sep 17, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 17, 2020

Waiting on #56.

Signed-off-by: Nate Koenig nate@openrobotics.org

Preparing for 1.9.0 release
eafb33a 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from mxgrey as a code owner September 17, 2020 04:16
@nkoenig nkoenig changed the base branch from master to ign-physics1 September 17, 2020 04:19
@chapulina
Copy link
Contributor

Is there time for a pre-release or is this urgent?

@chapulina chapulina added the 📜 blueprint Ignition Blueprint label Sep 17, 2020
@nkoenig
Copy link
Contributor Author

nkoenig commented Sep 17, 2020

Is there time for a pre-release or is this urgent?

Go for it. I'll need to make a release tomorrow though. Is that okay?

@chapulina
Copy link
Contributor

chapulina commented Sep 17, 2020 •
edited
Loading

Go for it. I'll need to make a release tomorrow though. Is that okay?

Cool, let's add the pre1 suffix on this PR and trigger a pre-release. Then do some downstream testing in the morning and if everything is working as expected we should be ready for a stable release. We should also hear from @scpeters until then.

@chapulina
pre1
99b20a1 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 75473d1 into ign-physics1 Sep 17, 2020
@chapulina chapulina deleted the nate/1-9-0_prep branch September 17, 2020 04:32
@scpeters
Copy link
Member

yes to prerelease, then if things are looking good in testing we can make the stable release

@chapulina chapulina mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey mxgrey is a code owner

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkoenig @chapulina @scpeters