Fix finding ogre 2.3 installed from source #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
When building gz with ogre-next 2.3 from source, cmake has trouble finding ogre-next because the
OGRE2_LIBRARY_DIRS
is empty andOGRE2_RESOURCE_PATH
points to the incorrect dir.OGRE2_LIBRARY_DIRS
: Turns out that variable is set by aSTRING
REPLACE
call that never gets called because the if check before string replace seems incorrect - I updated to make sure the input string exists before doing the replace call (originally the logic checks that the input string does not exist).OGRE2_RESOURCE_PATH
: when built from source, the ogre plugins are installed to a dir calledOGRE-Next
instead ofOGRE
Tested with ogre-next 2.3 installed from https://github.com/gazebo-forks/ogre-next/tree/gazebo/v2-3
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.