Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In gz-cmake 3.2.2 FindGzOgre2 now can define OGRE2_RESOURCE_PATH as a list #361

Closed
traversaro opened this issue Jul 4, 2023 · 0 comments · Fixed by gazebosim/gz-rendering#867
Assignees
Labels
bug Something isn't working

Comments

@traversaro
Copy link
Contributor

Until #342 OGRE2_RESOURCE_PATH could only be defined as a CMake variable with a single string, while since #342 OGRE2_RESOURCE_PATH can also be a list of string.

In the case in which OGRE2_RESOURCE_PATH is a list of strings, downstream projects that consider OGRE2_RESOURCE_PATH to be a single string (such as gz-rendering, see https://github.com/gazebosim/gz-rendering/blob/gz-rendering7_7.4.0/ogre2/src/CMakeLists.txt#L21), a string that starts with " but not ended with " is passed to the compiler, resulting in this error:

2023-07-03T14:42:03.0953789Z /home/conda/feedstock_root/build_artifacts/gz-rendering7_1688394561041/_build_env/bin/x86_64-conda-linux-gnu-c++ -DHAVE_EGL=1 -DHAVE_GLX=1 -DOGRE_IGNORE_UNKNOWN_DEBUG -Dgz_rendering7_ogre2_EXPORTS -D/home/conda/feedstock_root/build_artifacts/gz-rendering7_1688394561041/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/OGRE-Next" -DOGRE2_RESOURCE_PATH=\"/home/conda/feedstock_root/build_artifacts/gz-rendering7_1688394561041/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/OGRE -DOGRE2_VERSION=\"2.3.1\" -DGLX_GLXEXT_LEGACY -O3 -DNDEBUG  -Wall -Wextra -Wno-long-long -Wno-unused-value -Wfloat-equal -Wshadow -Winit-self -Wswitch-default -Wmissing-include-dirs -pedantic  -std=c++17 -fPIC -fvisibility=default -msse -msse2 -mfpmath=sse -msse3 -mssse3 -msse4.1 -msse4.2 -fPIC -I/home/conda/feedstock_root/build_artifacts/gz-rendering7_1688394561041/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include/uuid -MD -MT ogre2/src/CMakeFiles/gz-rendering7-ogre2.dir/Ogre2RenderEngine.cc.o -MF ogre2/src/CMakeFiles/gz-rendering7-ogre2.dir/Ogre2RenderEngine.cc.o.d -o ogre2/src/CMakeFiles/gz-rendering7-ogre2.dir/Ogre2RenderEngine.cc.o -c /home/conda/feedstock_root/build_artifacts/gz-rendering7_1688394561041/work/ogre2/src/Ogre2RenderEngine.cc
2023-07-03T14:42:03.0961725Z /bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
2023-07-03T14:42:03.0962200Z /bin/sh: -c: line 1: syntax error: unexpected end of file

Environment

  • OS Version: Ubuntu 22.04 with conda-forge dependencies
  • Source or binary build? Source 21ddd8a

Steps to reproduce

This happened on conda-forge builds, but could happen on any platform in which OGRE2_RESOURCE_PATH ends up being a list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants