Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gzdev_project_name parameter #12

Merged
merged 32 commits into from
Jul 21, 2020
Merged

Support gzdev_project_name parameter #12

merged 32 commits into from
Jul 21, 2020

Conversation

j-rivero
Copy link
Contributor

The PR adds a new gzdev_project_name parameter to configuration available for jobs using this action.

  • If the parameter is not set, the current behaviour is preserved (install the stable repository). That should make migration comfortable.
  • If the parameter is set with a given project (i.e: ignition-transport) then the job installs gzdev tool, extract the major version of the software, and use it together with the parameter (i.e: ignition-transport9) to pass that to gzdev repository enable that should handle if that project requires stable, pre-release or nightly and install repositories according.

This PR includes the change in #11 that should go before in order to get a clear history of changes.

Testing:

j-rivero added 11 commits July 16, 2020 20:09
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
chapulina and others added 17 commits July 20, 2020 08:16
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@j-rivero j-rivero requested a review from chapulina July 21, 2020 22:32
@j-rivero
Copy link
Contributor Author

Test run https://github.com/j-rivero/ign-transport/runs/896323621. The changes in 5a0c3f5 should convert any repository name (including sdformat) into a valid entry for gzdev.

@chapulina
Copy link
Contributor

chapulina commented Jul 21, 2020

The changes in 5a0c3f5 should convert any repository name (including sdformat) into a valid entry for gzdev.

Thanks for that, I played a bit with bash string substitution and failed miserably 😬

@chapulina chapulina merged commit c287b9a into master Jul 21, 2020
@chapulina chapulina deleted the gzdev branch July 21, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants