Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix health check library predicate & LastTransitionTime #2307

Merged
merged 1 commit into from
May 11, 2020
Merged

Fix health check library predicate & LastTransitionTime #2307

merged 1 commit into from
May 11, 2020

Conversation

danielfoehrKn
Copy link
Contributor

@danielfoehrKn danielfoehrKn commented May 8, 2020 •
edited
Loading

What this PR does / why we need it:
There was a regression introduced with my previous PR not discover during testing.
This leads to too many reconciles when the Extension.status is updated.

Also fixes the health check condition LastTransition time.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed a bug in the health check library that leads to too many health checks being executed when the Extension.Status changes.

Fixed the health check condition.lastTransitionTime in the health check library.

@danielfoehrKn danielfoehrKn requested a review from a team as a code owner May 8, 2020 16:23
@ialidzhikov
Copy link
Member

ialidzhikov commented May 8, 2020 •
edited
Loading

If it is a bug which you want to cherry-pick on extension, then don't rebase it on PR which is not merged in g/g.

@danielfoehrKn
Copy link
Contributor Author

@ialidzhikov it is not based on this PR I was mentioning in the description. It was only a hint for reviewers that, if the mentioned PR is merged, this PR has to be rebased. I removed the comment as I see it is confusing.

@ialidzhikov ialidzhikov self-assigned this May 10, 2020
rfranzke
rfranzke reviewed May 11, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK overall, but I didn't play with it. One question about the error handling.

extensions/pkg/controller/healthcheck/reconciler.go Show resolved Hide resolved
@rfranzke
Copy link
Member

/kind/bug

@ghost ghost added the kind/bug Bug label May 11, 2020
@danielfoehrKn danielfoehrKn force-pushed the quality/healthcheck-too-frequent-reconcile branch from ed1a6a1 to 1677870 Compare May 11, 2020 14:42
ialidzhikov
ialidzhikov approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit be60f8d into gardener:master May 11, 2020
@ialidzhikov ialidzhikov mentioned this pull request May 11, 2020
Merged
@timebertt timebertt assigned timebertt and unassigned timebertt May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees

@ialidzhikov ialidzhikov

Labels
kind/bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danielfoehrKn @ialidzhikov @rfranzke @gardener-robot-ci-1 @timebertt @gardener-robot-ci-2