Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension health checks support Progressing status #2289

Merged
merged 1 commit into from
May 14, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented May 6, 2020

What this PR does / why we need it:
With this PR the extension health check library is enhanced to allow individual health checks to return the Progressing status. This is helpful in order to provide more accurate status information and less false negative reports.

Also, the worker extension health check particularly was improved. It can now better detect regular scale-down and scale-up situations. Consequently, the "too many nodes" check was removed from Gardener's generic health check and moved into the responsibility of the worker extension health check (as it can more accurately determine what is going on).

Release note:

The extension health check library does now allow individual health checks to return the `Progressing` status. This allows to provide more accurate status information and less false negative health reports.

@rfranzke
Copy link
Member Author

rfranzke commented May 6, 2020

/kind/enhancement

@ghost ghost added the kind/enhancement Enhancement, improvement, extension label May 6, 2020
Copy link
Contributor

@danielfoehrKn danielfoehrKn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me - nice to have now error codes & progressing condition status allowing more sophisticated health checks in general.
Have you already build an image that I can re-use for testing it with the extension providers?

docs/extensions/healthcheck-library.md Outdated Show resolved Hide resolved
@rfranzke
Copy link
Member Author

rfranzke commented May 7, 2020

Have you already build an image that I can re-use for testing it with the extension providers?

No, I haven't built an image, I was revendoring the AWS provider, started it locally on my machine and then performed my tests (easier/faster turn-around cycle).

Copy link
Contributor

@danielfoehrKn danielfoehrKn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me. Only nits regarding logging.

Maybe as a special remark for reviewers you could add next time that you have to add the

			scheme.AddKnownTypes(machinev1alpha1.SchemeGroupVersion,
				&machinev1alpha1.MachineDeploymentList{},
				&machinev1alpha1.MachineSetList{},
				&machinev1alpha1.MachineList{},
			)

to the scheme in the extension provider- in case reviewers are not aware.

extensions/pkg/controller/healthcheck/reconciler.go Outdated Show resolved Hide resolved
extensions/pkg/controller/healthcheck/worker/helpers.go Outdated Show resolved Hide resolved
@danielfoehrKn
Copy link
Contributor

Build is failing

@rfranzke
Copy link
Member Author

/needs/review

@ghost ghost added the needs/review label May 12, 2020
@timebertt timebertt self-assigned this May 12, 2020
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good, I have only minor comments for you :)

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, only the loop thingy left :)

Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for incorporating my suggestions.
/lgtm now

@rfranzke
Copy link
Member Author

@danielfoehrKn any more feedback?

@rfranzke rfranzke merged commit f9151e7 into gardener:master May 14, 2020
@rfranzke rfranzke deleted the feature/extension-health-check branch May 14, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants