Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GetConfigmapName consistent #467

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/utils/names.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func GetServiceAccountName(etcd *druidv1alpha1.Etcd) string {

// GetConfigmapName returns the name of the configmap based on the given `etcd` object.
func GetConfigmapName(etcd *druidv1alpha1.Etcd) string {
return fmt.Sprintf("etcd-bootstrap-%s", string(etcd.UID[:6]))
return fmt.Sprintf("%s-bootstrap-%s", etcd.Name, string(etcd.UID[:6]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need some cleanup logic.

}

// GetCronJobName returns the legacy compaction cron job name
Expand Down