Make GetConfigmapName consistent
#467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfranzke Thanks a lot for the PR. Can you please also adapt the tests to use " |
timuthy
reviewed
Nov 18, 2022
| @@ -37,7 +37,7 @@ func GetServiceAccountName(etcd *druidv1alpha1.Etcd) string { | |||
|
|
|||
| // GetConfigmapName returns the name of the configmap based on the given `etcd` object. | |||
| func GetConfigmapName(etcd *druidv1alpha1.Etcd) string { | |||
| return fmt.Sprintf("etcd-bootstrap-%s", string(etcd.UID[:6])) | |||
| return fmt.Sprintf("%s-bootstrap-%s", etcd.Name, string(etcd.UID[:6])) | |||
There was a problem hiding this comment.
I think we also need some cleanup logic.
|
@rfranzke You need rebase this pull request with latest master branch. Please check. |
|
@rfranzke we will take this up later and make the name consistent. This also helps in looking at config-maps. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
What this PR does / why we need it:
All other resources are prefixed with the
etcd.Namebut theConfigMapis not. This PR fixes this.Release note: