Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for converter #348

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add check for converter #348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion galaxy/files/rules/k8s_container_mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def k8s_container_mapper(tool, referrer, k8s_runner_id="k8s"):
# 3. If no explicit rule mapping was defined, and it's a tool that
# requires galaxy_lib, force the default container. Otherwise,
# Galaxy's default container resolution will apply.
if tool.id in GALAXY_LIB_TOOLS_UNVERSIONED or ("CONVERTER_" in tool.id and "CONVERTER_" == tool.id[:10]):
if tool.id in GALAXY_LIB_TOOLS_UNVERSIONED or ("CONVERTER_" in tool.id and "CONVERTER_" == tool.id[:10]) or tool.is_datatype_converter:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@almahmoud Since the .is_datatype_converter property is available, do we still need CONVERTER in tool.id?

default_container = params.get('docker_default_container_id')
if default_container:
params['docker_container_id_override'] = default_container
Expand Down