Add check for converter #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
afgane
approved these changes
Jan 27, 2022
nuwang
reviewed
Jan 28, 2022
| @@ -89,7 +89,7 @@ def k8s_container_mapper(tool, referrer, k8s_runner_id="k8s"): | |||
| # 3. If no explicit rule mapping was defined, and it's a tool that | |||
| # requires galaxy_lib, force the default container. Otherwise, | |||
| # Galaxy's default container resolution will apply. | |||
| if tool.id in GALAXY_LIB_TOOLS_UNVERSIONED or ("CONVERTER_" in tool.id and "CONVERTER_" == tool.id[:10]): | |||
| if tool.id in GALAXY_LIB_TOOLS_UNVERSIONED or ("CONVERTER_" in tool.id and "CONVERTER_" == tool.id[:10]) or tool.is_datatype_converter: | |||
There was a problem hiding this comment.
@almahmoud Since the .is_datatype_converter property is available, do we still need CONVERTER in tool.id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref galaxyproject/galaxy#13255 (comment)
(tested manually with
csv_to_tabular)