Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux and Windows for with-flutter example #130

Merged
merged 21 commits into from
Oct 28, 2021
Merged

Conversation

Desdaemon
Copy link
Contributor

No example for MacOS since I do not own a machine, but the process should be similar to Linux.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 27, 2021

Thanks! Let me have a look

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 27, 2021

Thank you so much! Same as #128, could you please make some little changes as follows:

  • Could you please modify (or add) subsection in this section of readme, explaining what a user should do to run example in windows
  • Could you please add a line in changelog
  • Could you please add some tests in the GitHub CI in this file (just following the existing flutter_android_test/flutter_ios_test and add a flutter_windows_test) - this will ensure that it still works on windows in the future development of this lib, and also provides a command-by-command reference to anyone who wants more detail in reproducing it.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 28, 2021

Hmm Error waiting for a debug connection: The log reader stopped unexpectedly. this is quite strange... What about https://stackoverflow.com/questions/60729054/on-running-default-app-flutter-throws-log-reader-stopped-unexpectedly-after-s and flutter/flutter#79723?

@Desdaemon
Copy link
Contributor Author

I think the funniest thing that came out of this is that Windows worked from the first run, while Ubuntu is croaking from some obscure error 😓

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 28, 2021

I agree. The ubuntu thing seems quite strange...
Can it be a problem of github actions' ubuntu? Shall we open an issue in Flutter repo, or ticket to GitHub?

@Desdaemon
Copy link
Contributor Author

I'm thinking after this we might open a ticket on the Flutter repo, I don't think there's much I can do for CI/CD at this point. FWIW tests run OK on my local machine.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 28, 2021

Ok... So maybe just comment out (do not delete - otherwise we will completely forget it) the linux-testing lines in CI yaml, and I will merge it.

@fzyzcjy fzyzcjy merged commit 00e7c2a into fzyzcjy:master Oct 28, 2021
@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 28, 2021

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants