Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows support for example #128

Closed
wants to merge 2 commits into from

Conversation

smw-wagnerma
Copy link

added windows desktop support to the example, works fine. Only the rust dll must be copied to build/windows/runner/Debug, perhaps cargo can handle it and copy it the right location for each plattform.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 26, 2021

Thank you so much! Just a few small questions:

  • I wonder where the ~1000loc comes from - I guess firstly follow the Flutter's official Desktop tutorial, and then edit a bit of our .dart code?
  • Could you please modify (or add) subsection in this section of readme, explaining what a user should do to run example in windows
  • Could you please add a line in changelog
  • Could you please add some tests in the GitHub CI in this file (just following the existing flutter_android_test/flutter_ios_test and add a flutter_windows_test) - this will ensure that it still works on windows in the future development of this lib, and also provides a command-by-command reference to anyone who wants more detail in reproducing it.

@Desdaemon
Copy link
Contributor

Might be off topic, but I found a way to have CMake build Rust crates and automatically add them to the correct folders via corrosion. If there is interest I will make a minimum example.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 28, 2021

#130 has been merged so I closed this. Feel free to reopen if this still needs to be merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants