Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework version comparison have a strong opinion about silverlight #1124

Closed
vbfox opened this issue Oct 9, 2015 · 1 comment
Closed

Framework version comparison have a strong opinion about silverlight #1124

vbfox opened this issue Oct 9, 2015 · 1 comment

Comments

@vbfox
Copy link
Contributor

vbfox commented Oct 9, 2015

This paket.references :

NLog framework: >= net46

Generate the following references :

<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Choose>
    <When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.6'">
      <ItemGroup>
        <Reference Include="NLog">
          <HintPath>..\packages\NLog\lib\net45\NLog.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
    <When Condition="$(TargetFrameworkIdentifier) == 'Silverlight' And $(TargetFrameworkVersion) == 'v4.0'">
      <ItemGroup>
        <Reference Include="NLog">
          <HintPath>..\packages\NLog\lib\sl4\NLog.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
    <When Condition="$(TargetFrameworkIdentifier) == 'Silverlight' And $(TargetFrameworkVersion) == 'v5.0'">
      <ItemGroup>
        <Reference Include="NLog">
          <HintPath>..\packages\NLog\lib\sl5\NLog.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
  </Choose>
</Project>

The framework comparison seem to think that silverlight is some sort of super version of the netXX framework that is always sorted after other versions.

Sliverlight is dead and comming back as a zombie framework ?

@forki
Copy link
Member

forki commented Oct 10, 2015

What's the concrete issue?
On Oct 9, 2015 21:49, "Julien Roncaglia" notifications@github.com wrote:

This paket.references :

NLog framework: >= net46

Generate the following references :

..\packages\NLog\lib\net45\NLog.dll True True ..\packages\NLog\lib\sl4\NLog.dll True True ..\packages\NLog\lib\sl5\NLog.dll True True

The framework comparison seem to think that silverlight is some sort of
super version of the netXX framework that is always sorted after other
versions.

Sliverlight is dead and comming back as a zombie framework ?


Reply to this email directly or view it on GitHub
#1124.

vbfox added a commit to vbfox/Paket that referenced this issue Oct 11, 2015
vbfox added a commit to vbfox/Paket that referenced this issue Oct 11, 2015
FrameworkIdentifier instances were compared structurally before but it
was problematic in some cases as '>= net45' matched 'sl40' that wasn't
in the same framework.

This commit add new operators (.>, .>=, .<, .<=) and methods (Min, Max,
IsSameFramework) to FrameworkIdentifier that do the comparison with the
expected semantic.

Fixes fsprojects#1124
vbfox added a commit to vbfox/Paket that referenced this issue Oct 15, 2015
vbfox pushed a commit to vbfox/Paket that referenced this issue Oct 15, 2015
FrameworkIdentifier instances were compared structurally before but it
was problematic in some cases as '>= net45' matched 'sl40' that wasn't
in the same framework.

Fixes fsprojects#1124
@forki forki closed this as completed in 001ab06 Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants