Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new copyright style with spdx and string c as per #948 #979

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Added new copyright style with spdx and string c as per #948 #979

merged 9 commits into from
Jul 23, 2024

Conversation

sin-ha
Copy link

@sin-ha sin-ha commented May 7, 2024

Fixes #948

@sin-ha sin-ha force-pushed the new-copyright-style branch from 7daa92b to 9153825 Compare May 7, 2024 06:19
@sin-ha sin-ha mentioned this pull request May 7, 2024
Closed
@garethsb
Copy link

garethsb commented May 7, 2024

To fully fix #948, needs to ensure _COPYRIGHT_PATTERNS matches all current and added styles.

Although I don't need them, adding spdx-string and spdx-string-symbol, would make the variations consistent?

@sin-ha sin-ha force-pushed the new-copyright-style branch from 0c03282 to 011ff4c Compare May 7, 2024 19:28
@sin-ha
Copy link
Author

sin-ha commented Jul 23, 2024

can you please take a look @carmenbianca

Harsh Sinha (SW-GPU) and others added 8 commits July 23, 2024 11:20
@carmenbianca
add new copyright prefix
2e1b931
@carmenbianca
make all combiantions with spdx prefix
da306fe
@carmenbianca
modify regex to support all spdx
8d60852
@carmenbianca
avoid regressions in regex matching
370d968
@carmenbianca
Revert "avoid regressions in regex matching"
5159d12 
This reverts commit 9b779e6.
@carmenbianca
Add new copyright prefixes to documentation
c7caaea 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Improve test against all copyright prefixes
4dd63e6 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Add merge test against all copyright prefixes
2538a66 
Co-Authored-By: sudorook
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca carmenbianca force-pushed the new-copyright-style branch from 9b779e6 to 2538a66 Compare July 23, 2024 09:24
@carmenbianca
Add change log entries
0e9bd7d 
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca
Copy link
Member

Hi @sin-ha, I've patched this up. I was reluctant to work on this because it's a bit of a behemoth and #947 is an issue I want to work on to refactor this whole mess.

Incidentally, I integrated #964 en passant. Thank you @sudorook !

@carmenbianca carmenbianca mentioned this pull request Jul 23, 2024
Closed
@carmenbianca carmenbianca merged commit 37f342d into fsfe:main Jul 23, 2024
15 checks passed
@garethsb
Copy link

@carmenbianca, thanks very much for adding the test cases and docs, agree refactoring per #947 is a good long term plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copyright styles and merging
3 participants
@sin-ha @garethsb @carmenbianca