Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright styles and merging #948

Closed
garethsb opened this issue Apr 8, 2024 · 4 comments · Fixed by #979
Closed

Copyright styles and merging #948

garethsb opened this issue Apr 8, 2024 · 4 comments · Fixed by #979
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@garethsb
Copy link

garethsb commented Apr 8, 2024

Currently supported styles:

    "spdx": "SPDX-FileCopyrightText:",
    "spdx-c": "SPDX-FileCopyrightText: (C)",
    "spdx-symbol": "SPDX-FileCopyrightText: ©",
    "string": "Copyright",
    "string-c": "Copyright (C)",
    "string-symbol": "Copyright ©",
    "symbol": "©",

The first issue I encountered is that none of the _COPYRIGHT_PATTERNS match the spdx-c style, so --merge-copyrights is not effective. A small tweak to the first pattern is sufficient - would a PR be accepted?

Secondly, I've been asked to use the (even more redundant) style: "SPDX-FileCopyrightText: Copyright (c) "...
Would a PR to add sdpx-string-c (etc.) be accepted?

Thanks!

@carmenbianca
Copy link
Member

Hi @garethsb , thanks for opening the issue!

The answer is yes to both. Contributions for this would be very welcome.

@carmenbianca carmenbianca added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Apr 8, 2024
@sin-ha
Copy link

sin-ha commented May 7, 2024

Hi @carmenbianca can you PTAL #979
TIA

@sin-ha
Copy link

sin-ha commented Jul 23, 2024

Pinging again @carmenbianca can you please take a look

carmenbianca added a commit that referenced this issue Jul 23, 2024
Added new copyright style with spdx and string c  as per #948
@sin-ha
Copy link

sin-ha commented Jul 24, 2024

Thanks a lot @carmenbianca any ideas on when this would be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants