Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pattern supporting use of value labels, categoricals and factors #844
Add pattern supporting use of value labels, categoricals and factors #844
Changes from 6 commits
6712fe4
d03ede0
ed2e978
0bf307b
b3aa02f
1a77c09
1df2118
04dc070
422c6b8
0510db3
6dd857a
5291b6d
a185de4
e38433d
5d82cf7
de004ba
bb8f093
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only hesitation about this proposal is the use of
enumLabels
instead ofmeta: enum
which would be consistent with Adobe's implementation ofjsonschema2md
. I'm inclined to make things match in name when they match in definition (which they do).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting to see it implemented the same. Personally I prefer keeping names consistent within the (Frictionless) schema and referring to concepts from other schemas using e.g.
"skos:exactMatch": "jsonschema2md/enums/meta:enum"
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to clarify in the specs (if its' not clarified yet) that
namespece: property
is a recommended way for metadata enrichment as in other specs like (csvw)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is clarified somewhere yet. I guess that clarification should not be part of this proposal, but can be recorded as a todo issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue - #845
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the external reference was to a standard or ontology, then I definitely see the value of using that, but
jsonschema2md
is a software application not explicitly intended to serve as a reference. Thus, I'm not sure what the added benefit would be overenumLabels
. But please let me know if I'm missing something here; glad to defer to those with greater knowledge.