-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pattern supporting use of value labels, categoricals and factors #844
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6712fe4
Add pattern supporting use of value labels, categoricals and factors
pschumm d03ede0
Changes suggested by reviewers @khughitt and @peterdesmet (thanks!)
pschumm ed2e978
Group enum-related properties next to each other
pschumm 0bf307b
Merge remote-tracking branch 'origin/master' into pschumm/categoricals
pschumm b3aa02f
Clarify proposed use of field-specific missingValues property
pschumm 1a77c09
Remove field-specific missingValues property
pschumm 1df2118
Update patterns/README.md
pschumm 04dc070
Update patterns/README.md
pschumm 422c6b8
Update patterns/README.md
pschumm 0510db3
Update patterns/README.md
pschumm 6dd857a
Update patterns/README.md
pschumm 5291b6d
Update patterns/README.md
pschumm a185de4
Update patterns/README.md
pschumm e38433d
Update patterns/README.md
pschumm 5d82cf7
Minor edit to eliminate ambiguity
pschumm de004ba
Fix syntax (thanks @khusmann!)
pschumm bb8f093
Add missing comma
pschumm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only hesitation about this proposal is the use of
enumLabels
instead ofmeta: enum
which would be consistent with Adobe's implementation ofjsonschema2md
. I'm inclined to make things match in name when they match in definition (which they do).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting to see it implemented the same. Personally I prefer keeping names consistent within the (Frictionless) schema and referring to concepts from other schemas using e.g.
"skos:exactMatch": "jsonschema2md/enums/meta:enum"
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to clarify in the specs (if its' not clarified yet) that
namespece: property
is a recommended way for metadata enrichment as in other specs like (csvw)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that is clarified somewhere yet. I guess that clarification should not be part of this proposal, but can be recorded as a todo issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue - #845
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the external reference was to a standard or ontology, then I definitely see the value of using that, but
jsonschema2md
is a software application not explicitly intended to serve as a reference. Thus, I'm not sure what the added benefit would be overenumLabels
. But please let me know if I'm missing something here; glad to defer to those with greater knowledge.