More e2e Cleanups and Improvements #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api -> apiPromise
Handles Remove unused helper
Remove unneeded fund and send Funds for staking Staking uses signAndSend
wilwade
commented
Nov 3, 2023
|
|
||
| const failStakeObj = ExtrinsicHelper.stake(stakeKeys, maxMsaId + 1, stakeAmount); |
There was a problem hiding this comment.
Because this test is running in parallel, it cannot just use maxMsaId + 1 as other msas are being created and might be providers.
wilwade
commented
Nov 3, 2023
| @@ -38,212 +36,4 @@ describe("Create Accounts", function () { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("addPublicKeyToMsa", function () { | |||
There was a problem hiding this comment.
Moved to msaKeyManagemement.test.ts for less dependent tests
wilwade
commented
Nov 3, 2023
There was a problem hiding this comment.
Moved from msa/createMsa.test.ts
wilwade
commented
Nov 3, 2023
| @@ -221,10 +221,6 @@ export class ExtrinsicHelper { | |||
| return ExtrinsicHelper.apiPromise.query.schemas.governanceSchemaModelMaxBytes(); | |||
| } | |||
|
|
|||
| public static getCurrentMsaIdentifierMaximum() { | |||
wilwade
commented
Nov 3, 2023
| @@ -407,20 +424,19 @@ export async function getOrCreateAvroChatMessageItemizedSchema(source: KeyringPa | |||
|
|
|||
| export const TokenPerCapacity = 50n; | |||
|
|
|||
| export function assertEvent(events: EventMap, eventName: string) { | |||
There was a problem hiding this comment.
moved down with the other assert
wilwade
commented
Nov 3, 2023
There was a problem hiding this comment.
This file was missing .test.ts so it wasn't running.
mattheworris
reviewed
Nov 6, 2023
| const totalCapacity = (await getRemainingCapacity(stakeProviderId)).toBigInt(); | ||
| async function drainCapacity(call, stakeProviderId: u64): Promise<bigint> { | ||
| const totalCapacity = (await getCapacity(stakeProviderId)).totalCapacityIssued.toBigInt(); | ||
| let nonce = await getNonce(call.keys); |
There was a problem hiding this comment.
Nice, I didn't know you could do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is another pile of small e2e fixes and cleanups
Part of #1731
Discussion
signAndSendTesting
make e2e-tests