e2e-tests inconsistent #1731
Assignees
Comments
wilwade
added a commit
that referenced
this issue
Nov 1, 2023
# Goal The goal of this PR is to improve the e2e tests. NOTE: Parallel testing locally is still flaky. Another PR coming, but wanted to keep these separate for readability Part of #1731 # Discussion - Big Change: `signAndSend` now returns a correctly typed object! - This leads to a large number of basically the same change all over. - the default event (previously the `response[0]` field) now is typed, so no need to use `is` everywhere - Using `?` (`result?.data.msaId` for example) allows for a nice handling of the default event data - Using `!` (`result!.data.msaId` for example) allows for a nice throwing of the default event data when we expect it, but don't have it. (fine for tests) - A few small cleanups like removing unused imports - Additional helpful comments - Fixing an issue with handles test not being able to run more than 90 times in a row
wilwade
added a commit
that referenced
this issue
Nov 3, 2023
# Goal The goal of this PR is a small set of improvements: - Update e2e readme - Add additional debug logging defaults to the init.sh script for instant and interval sealing - Add a interval param to the interval sealing init.sh runner - Add serial run mode for e2e tests Part of #1731
wilwade
added a commit
that referenced
this issue
Nov 6, 2023
# Goal The goal of this PR is another pile of small e2e fixes and cleanups Part of #1731 # Discussion - Correctly name time release test - Move some msa tests into a separate file - Staking calls should always use `signAndSend` - Test handles for > 90 runs by using a random number generator - createMsa helper and using it for creating un-permissioned MSAs - Replace the rxjs with the apiPromise for rpc and state queries because they are faster and more reliable - getCapacity and DrainCapacity Improvements and cleanups - Serialize BigInts for Mocha (as sometimes it needs to serialize it)
wilwade
added a commit
that referenced
this issue
Nov 6, 2023
# Goal The goal of this PR is to make nonce management easy inside of e2e tests. This does it via a module that caches and then keeps a local state up. Part of #1731 # Discussion - RPC errors will NOT increment nonces, so those must use the `current` option - Also split up some of the handles tests to make this easier - Made sure everything was using `function ()` instead of `() =>` for mocha
wilwade
added a commit
that referenced
this issue
Nov 8, 2023
# Goal The goal of this PR is the final misc pieces of getting the e2e tests less flaky. Does this fix all of it? No. Most? Yes. Closes #1731 # Discussion - Correct batch error asserting - Ids used as "bad" should use close to the max - Use Immortal Eras due to issues with speed and [AncientBirthBlock](https://substrate.stackexchange.com/questions/10411/fast-block-production-causes-mortality-checking-failing-with-ancientbirthblock) - Cleanup before funding - Move assertAddNewKey - Add new assertHasMessage
rustadot
pushed a commit
to rustadot/recurrency
that referenced
this issue
Sep 5, 2024
# Goal The goal of this PR is a small set of improvements: - Update e2e readme - Add additional debug logging defaults to the init.sh script for instant and interval sealing - Add a interval param to the interval sealing init.sh runner - Add serial run mode for e2e tests Part of frequency-chain/frequency#1731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
e2e tests seem to pause when starting a node and then running
make e2e-tests.When running
make e2e-testsit sometimes outputs1010: Invalid Transaction: Transaction is outdated.The text was updated successfully, but these errors were encountered: