Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cleanup #85

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Build cleanup #85

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4854ee5
Garbage collect stray reference to auto_array
ngie-eign Dec 6, 2024
20b4177
Require C++-14 at bare minimum
ngie-eign Dec 6, 2024
6a87825
Stop shipping atf-*-api(3) manpages
ngie-eign Dec 8, 2024
43f768c
Expose WCOREDUMP(..) in a deterministic manner
ngie-eign Dec 8, 2024
7e06447
Add compiler feature detection for `__attribute__((nonnull))`
ngie-eign Dec 10, 2024
e6488d4
Restore AC_PROG_CPP
ngie-eign Dec 25, 2024
b3f2769
atf-c/detail/env.c: remove unnecessary complexity
ngie-eign Dec 8, 2024
732040d
Remove ATF_BUILD_CXX require.progs check
ngie-eign Dec 26, 2024
de512c3
Remove redundant C++ toolchain check
ngie-eign Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ AC_USE_SYSTEM_EXTENSIONS

AC_PROG_CXX
AC_LANG_COMPILER(C++)
AC_PROG_CPP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Is this where it belongs though, it seems the CXX and C++ bits should be together without CPP in the middle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to run through it again, but the order for invoking the macros is a bit fragile (autoconf/automake whine a lot about not calling things in the right order).

AX_CXX_COMPILE_STDCXX(14, noext, mandatory)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

AC_CACHE_CHECK([whether the C++ compiler works],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

[atf_cv_prog_cxx_works],
Expand Down