Build cleanup #85
Open
Build cleanup #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ce107f to
f054eeb
Compare
This entry should have been removed in the referenced commit. Fixes: 6639d08
This change imports ac_cxx_compile_stdcxx.m4 from gnu,org and makes use of the `AX_CXX_COMPILE_STDCXX` macro in configure.ac to ensure that the compiler specified supports C++-14 (at bare minimum). This is being done to quell some issues reported by scan-build about the code using C++ range-based for-loops (a feature added in C++-11).
These manpages have been deprecated for at least a release. Remove them and all of the logic associated with them. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
WCOREDUMP is considered an extension to the POSIX spec on multiple platforms, and thus is not automatically exposed on all platforms. Add the relevant preprocessor defines to config.h via autoconf, then leverage them in atf-c(3). This helps ensure that the platforms which support WCOREDUMP properly expose the macro. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
This feature is being detected so several functions can be appropriately marked as taking non-NULL/-nullptr parameters, and the compiler and static analyzers can (in turn) make intelligent decisions when optimizing and analyzing code, respectively. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
This was accidentally deleted post-0.21 release. It's still needed by tests and build infrastructure. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
The libcalls used have been in the POSIX standard since 2008.1. Require them to be present instead of conditionally hoping they're present. This fixes an issue where the autoconf code was messing up with a combination of clang tools, which resulted in the autoconf code failing to properly determine whether or not the functions were available. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
This particular check unfortunately doesn't work when ATF_BUILD_CXX contains multiple CXXFLAGS, or contains a path with spaces in it. Remove this check to unbreak the dependent tests post-793d4640031dc06ce8a239ffa9ab61322104c4ca. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
The C++ toolchain is sanity checked when C++14 conformance is checked; there's no reason why we need to check whether or not the C++ toolchain works again. Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
f054eeb to
de512c3
Compare
emaste
reviewed
Dec 29, 2024
| @@ -25,7 +25,6 @@ | |||
|
|
|||
| libatf_c___la_SOURCES += atf-c++/detail/application.cpp \ | |||
| atf-c++/detail/application.hpp \ | |||
| atf-c++/detail/auto_array.hpp \ | |||
emaste
reviewed
Dec 29, 2024
| AC_PROG_CXX | ||
| AC_LANG_COMPILER(C++) | ||
| AX_CXX_COMPILE_STDCXX(14, noext, mandatory) |
emaste
reviewed
Dec 29, 2024
| @@ -114,12 +114,4 @@ clean-all: | |||
|
|
|||
| .PHONY: $(PHONY_TARGETS) | |||
|
|
|||
| # TODO(jmmv): Remove after atf 0.22. | |||
emaste
reviewed
Dec 29, 2024
| @@ -62,6 +62,7 @@ AC_USE_SYSTEM_EXTENSIONS | |||
|
|
|||
| AC_PROG_CXX | |||
| AC_LANG_COMPILER(C++) | |||
| AC_PROG_CPP | |||
There was a problem hiding this comment.
OK. Is this where it belongs though, it seems the CXX and C++ bits should be together without CPP in the middle
There was a problem hiding this comment.
I'll have to run through it again, but the order for invoking the macros is a bit fragile (autoconf/automake whine a lot about not calling things in the right order).
emaste
reviewed
Dec 29, 2024
| @@ -65,50 +61,19 @@ atf_env_set(const char *name, const char *val) | |||
| { | |||
| atf_error_t err; | |||
|
|
|||
| #if defined(HAVE_SETENV) | |||
emaste
reviewed
Dec 29, 2024
| @@ -64,16 +64,6 @@ AC_PROG_CXX | |||
| AC_LANG_COMPILER(C++) | |||
| AC_PROG_CPP | |||
| AX_CXX_COMPILE_STDCXX(14, noext, mandatory) | |||
| AC_CACHE_CHECK([whether the C++ compiler works], | |||
|
I've marked the files I've reviewed so far |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some build bugs and adds some build enhancements:
auto_array(bugfix).atf-*-apimanpages (enhancement).-std=C++14with ATF (enhancement).WCOREDUMP(..)macro on platforms which support it via autotools (bugfix).__attribute__((nonnull))support, similar to__attribute__((unused)), et al (enhancement).AC_PROG_CPP(bugfix).