Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accounting-dimension): validate accounting dimension company in journal entry and stock entry #45922

Closed
wants to merge 82 commits into from
Closed

fix(accounting-dimension): validate accounting dimension company in journal entry and stock entry #45922

wants to merge 82 commits into from

Conversation

Bhavan23
Copy link
Contributor

Issue: Journal Entry and Stock Entry not validating accounting dimension company

ref: 31652

Before

1.issue.webm

After

2.fix.webm

Backport Needed: v15 & v14

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Feb 14, 2025
rohitwaghchaure and others added 27 commits February 20, 2025 16:02
@rohitwaghchaure @Bhavan23
fix: allow scrap item with zero qty
5556bb7
@diptanilsaha @Bhavan23
feat: disable auto setting grand total to default mode of payment (fr…
4656fc2 
…appe#45591)
@Navin-S-R @Bhavan23
fix: include missing payment_gateway parameter in Payment Request URL
3103ad6
@frappe-pr-bot @Bhavan23
fix: sync translations from crowdin (frappe#45876)
2277595 
* fix: Swedish translations

* fix: Turkish translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Spanish translations

* fix: Swedish translations

* fix: Turkish translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Swedish translations

* fix: Turkish translations

* fix: Chinese Simplified translations

* fix: Persian translations

* fix: Bosnian translations
@diptanilsaha @Bhavan23
fix: prevent duplicate pos fields in pos settings (frappe#45873)
d18c8c9 
fix: restrict duplicate pos fields in pos settings
@diptanilsaha @Bhavan23
fix: pos accounting dimension fieldname error (frappe#45899)
d4d33ed 
* fix: pos accounting dimension fieldname error

* fix: method to get enabled accounting dimensions

* fix: fetch enabled accounting dimensions

* fix: clear flags for accounting_dimensions_details on_update

* refactor: validation for doctype

* fix: using get_checks_for_pl_and_bs_accounts for accounting dimensions
@rohitwaghchaure @Bhavan23
fix: start reposting button not working
44e78b2
@frappe-pr-bot @Bhavan23
chore: update POT file (frappe#45935)
7cb3725
@ruthra-kumar @Bhavan23
refactor: remove party_balance
b12ae63
@ruthra-kumar @Bhavan23
refactor: remove paid_from_account_balance
5e00d99
@ruthra-kumar @Bhavan23
refactor: remove paid_to_account_balance
31bd452
@rohitwaghchaure @Bhavan23
fix: letter head for quality inspection
5b144f2
@diptanilsaha @Bhavan23
fix: disable partial payment in pos (frappe#45752)
5a193ad 
* fix: disable partial payment in pos

* test: disable partial payment

* test: removed print statement

* test: using save method to auto calculate paid_amount

* test: paid_amount calculation using save method

* test: added save method to calculate paid_amount

* test: outstanding amount

* test: added test for partial payments in pos invoice

* fix: custom validation error for partial payment

* test: using partial payment validation

* fix: validate only on submit
@diptanilsaha @Bhavan23
fix: improve pos return (frappe#45671)
c2d459a 
* fix: pos return validation for zero qty item

* fix: pos return invoice onload ui

* feat: added item qty returned in pos ui

* refactor: removed console log statement

* feat: check return can be made before loading it on pos

* fix: pos edit invoice onload ui

* fix: returned

* refactor: code cleanup
@0xD0M1M0 @Bhavan23
fix: auto create asset due to message error (frappe#45934)
af843dc 
* fix: auto create asset due to message error

* fix: linters
@sokumon @Bhavan23
Small UI changes (frappe#45938)
0537564 
* fix: change erpnext logo and home workpsace icon

* fix: actually change home workspace icon

* fix: typo in hooks.py
@rohitwaghchaure @Bhavan23
fix: remove unused fields
f3f2a50
@rohitwaghchaure @Bhavan23
fix: provision to enable naming series for SABB
4d86f3c
@frappe-pr-bot @Bhavan23
fix: sync translations from crowdin (frappe#45927)
1be3a25 
* fix: Swedish translations

* fix: Bosnian translations

* fix: Bosnian translations

* fix: French translations

* fix: Spanish translations

* fix: Arabic translations

* fix: Hungarian translations

* fix: Polish translations

* fix: Russian translations

* fix: Swedish translations

* fix: Turkish translations

* fix: Chinese Simplified translations

* fix: Persian translations

* fix: Bosnian translations

* fix: German translations

* fix: Esperanto translations
@rs-rethik @Bhavan23
fix: add validate to allow equity account and party_type shareholder
b236dcb
@rs-rethik @Bhavan23
test: add unit test to validate account type and party type
f1076dc
@rs-rethik @Bhavan23
fix: remove party type from validate
ced538e
@diptanilsaha @Bhavan23
fix: pos checkout button color on dark mode (frappe#45967)
a579a9c
@frappe-pr-bot @Bhavan23
fix: Swedish translations
ea29c39
@frappe-pr-bot @Bhavan23
fix: Bosnian translations
a071e22
@frappe-pr-bot @Bhavan23
fix: German translations
a7d53c8
@Sugesh393 @Bhavan23
fix: validate payment request total of partly paid invoice
dbc1dcc
casesolved-co-uk and others added 27 commits February 20, 2025 16:06
@casesolved-co-uk @Bhavan23
fix: remove public access to list items
8097735
@akhilnarang @Bhavan23
fix(send_message): escape HTML in the text
18b987f 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@khushi8112 @Bhavan23
fix: reset location only if there is value in row item location field
606ad38
@rohitwaghchaure @Bhavan23
fix: incorrect stock value difference for adjustment entry
63cd068
@frappe-pr-bot @Bhavan23
fix: sync translations from crowdin (frappe#45997)
fd37a2f
@rohitwaghchaure @Bhavan23
fix: inventory dimension for maintence visit
25097d2
@diptanilsaha @Bhavan23
fix: pos opening entry dialog not saving on change data (frappe#46066)
97aee1a
@ravibharathi656 @barredterra @Bhavan23
feat: add total weight in shipment (frappe#46049)
08118d5 
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
@0xD0M1M0 @Bhavan23
fix: discount accounting
2025fb7
@0xD0M1M0 @Bhavan23
fix: only negative for "Pay"
c2f193f
@0xD0M1M0 @Bhavan23
feat: add testcase for discount_payment_entry
7eb8d15
@frappe-pr-bot @Bhavan23
fix: sync translations from crowdin (frappe#46036)
b86a9fa 
* fix: Persian translations

* fix: Bosnian translations

* fix: Turkish translations

* fix: Persian translations

* fix: Bosnian translations
@frappe-pr-bot @Bhavan23
fix: sync translations from crowdin (frappe#46111)
8bc8da5 
* fix: Spanish translations

* fix: Swedish translations

* fix: Bosnian translations

* fix: Persian translations

* fix: Bosnian translations
@ankush @Bhavan23
fix(patch): Ensure SLE indexes (frappe#46131)
f105d08 
Because of the way this change was pushed in parts, some sites don't see
this as "update" and don't have the new indexes.
@Ninad1306 @Bhavan23
fix(report): allow Closed purchase orders to be visible
d31aafd
@Ninad1306 @Bhavan23
fix(report): allow Closed sales orders to be visible
789c0d3
@Ninad1306 @Bhavan23
fix(report): filter sales / purchase orders based on date filters
24c7c2d
@venkat102 @Bhavan23
fix(project settings): add checkbox to auto fetch timesheet in sales …
7670148 
…invoice
@venkat102 @Bhavan23
fix(sales invoice): check fetch_timesheet_in_sales_invoice enabled be…
cf028da 
…fore fetching the timesheet
@venkat102 @Bhavan23
fix: check value as int
80e9635
@venkat102 @Bhavan23
fix: enable fetch_timesheet_in_sales_invoice in test
7ea1867
@rohitwaghchaure @Bhavan23
fix: valuation rate for batch
51a016d
@venkat102 @Bhavan23
fix: no permission to get project settings in sales invoice
d3d8e0f
@frappe-pr-bot @Bhavan23
fix: Bosnian translations
4c2ae84
@Bhavan23
test: modified test cases to reflect new accounting dimension validat…
de5e219 
…ion rules based on company
@Bhavan23
Merge branch 'develop' into import-accounting-dimention-validation
190569b
@Bhavan23
test: modified test cases to reflect new accounting dimension validat…
1849352 
…ion rules based on company
@Bhavan23 Bhavan23 changed the title fix(accounting dimension): validate accounting dimension company in journal entry and stock entry fix(accounting-dimension): validate accounting dimension company in journal entry and stock entry Feb 27, 2025
@Bhavan23 Bhavan23 closed this Feb 28, 2025
@Bhavan23 Bhavan23 deleted the import-accounting-dimention-validation branch February 28, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar will be requested when the pull request is marked ready for review ruthra-kumar is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure will be requested when the pull request is marked ready for review rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.