fix: pos accounting dimension fieldname error #45899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
approved these changes
Feb 14, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* fix: pos accounting dimension fieldname error * fix: method to get enabled accounting dimensions * fix: fetch enabled accounting dimensions * fix: clear flags for accounting_dimensions_details on_update * refactor: validation for doctype * fix: using get_checks_for_pl_and_bs_accounts for accounting dimensions (cherry picked from commit 60a5f4f) # Conflicts: # erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.py
diptanilsaha
added a commit
to diptanilsaha/erpnext
that referenced
this pull request
Feb 14, 2025
* fix: pos accounting dimension fieldname error * fix: method to get enabled accounting dimensions * fix: fetch enabled accounting dimensions * fix: clear flags for accounting_dimensions_details on_update * refactor: validation for doctype * fix: using get_checks_for_pl_and_bs_accounts for accounting dimensions
diptanilsaha
added a commit
that referenced
this pull request
Feb 17, 2025
* fix: pos accounting dimension fieldname error (#45899) * fix: pos accounting dimension fieldname error * fix: method to get enabled accounting dimensions * fix: fetch enabled accounting dimensions * fix: clear flags for accounting_dimensions_details on_update * refactor: validation for doctype * fix: using get_checks_for_pl_and_bs_accounts for accounting dimensions (cherry picked from commit 60a5f4f) # Conflicts: # erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.py * chore: resolve conflict * chore: resolve linter issue * fix: resolve linter issue * chore: resolve linter issue * chore: resolve linter issue * chore: resolve linter issue --------- Co-authored-by: Diptanil Saha <diptanil@frappe.io>
diptanilsaha
added a commit
to diptanilsaha/erpnext
that referenced
this pull request
Feb 17, 2025
* fix: pos accounting dimension fieldname error * fix: method to get enabled accounting dimensions * fix: fetch enabled accounting dimensions * fix: clear flags for accounting_dimensions_details on_update * refactor: validation for doctype * fix: using get_checks_for_pl_and_bs_accounts for accounting dimensions
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
# [15.53.0](v15.52.0...v15.53.0) (2025-02-19) ### Bug Fixes * add accounting dimensions section in sales order item ([b32e4da](b32e4da)) * add is_new in if condition ([fc2ec7c](fc2ec7c)) * add validate to allow equity account and party_type shareholder ([bb3eb81](bb3eb81)) * allow scrap item with zero qty ([abe5384](abe5384)) * auto create asset due to message error (backport [#45934](#45934)) ([#45952](#45952)) ([830edb8](830edb8)) * check if employee is currently working on another workstation ([22eaa14](22eaa14)) * disable partial payment in pos (backport [#45752](#45752)) ([#45945](#45945)) ([38edc46](38edc46)) * do not reschedule depreciation for fully depreciated asset on scrap ([1e7c5ec](1e7c5ec)) * fetch child account data for selected parent ([#45904](#45904)) ([e36b860](e36b860)) * handle division by zero error (backport [#45966](#45966)) ([#46015](#46015)) ([15106b4](15106b4)) * include missing payment_gateway parameter in Payment Request URL ([18f9476](18f9476)) * letter head for quality inspection ([c289fef](c289fef)) * link correct row item of purchase doc ([87f337b](87f337b)) * make purchase_receipt_item and purchase_invoice_item fields of data type ([281431e](281431e)) * millisecond issue for posting datetime ([4292365](4292365)) * patch for creating asset depreciation schedule records ([f043b46](f043b46)) * pos accounting dimension fieldname error (backport [#45899](#45899)) ([#45921](#45921)) ([e998f06](e998f06)) * **pos profile:** check company while validating mandatory accounting dimension ([#45974](#45974)) ([6a57743](6a57743)) * pos return validation on v15 ([#45951](#45951)) ([dd34bbe](dd34bbe)) * provision to enable naming series for SABB ([8fbfe14](8fbfe14)) * **quotation:** fetch exchange rate on currency change ([bd89c19](bd89c19)) * remove party type from validate ([0d21151](0d21151)) * remove public access to list items (backport [#45838](#45838)) ([#46018](#46018)) ([eead6d4](eead6d4)) * remove unused code ([dd5d144](dd5d144)) * **report:** add options to multiselectlist fields ([7e85a12](7e85a12)) * reset location only if there is value in row item location field ([a509568](a509568)) * resolved conflicts ([84647a1](84647a1)) * round sum amount in JE auditing PF ([#45961](#45961)) ([44e1ca9](44e1ca9)) * **send_message:** escape HTML in the text ([cbec989](cbec989)) * serial no status for internal transfer delivery note ([2b80c00](2b80c00)) * set default value to 0 as per new logic ([1abe1a1](1abe1a1)) * set sco_qty field of PO to non negative ([567fb8a](567fb8a)) * slow query ([8306d6f](8306d6f)) * stock reservation for sales invoice ([1fb5586](1fb5586)) * stock reservation not working for sales invoice with update stock ([7d871f6](7d871f6)) * tests ([f63a9db](f63a9db)) * throw correct exception ([5bccf9f](5bccf9f)) * validate if no matching item found ([6183b38](6183b38)) * validate payment request total of partly paid invoice ([c8881a9](c8881a9)) ### Features * added ability to use custom html format for process statement of accounts (copy [#45746](#45746)) ([#46012](#46012)) ([1a4297a](1a4297a)) * added option to enforce free item qty in pricing rule ([8fb9228](8fb9228)) * disable auto setting grand total to default mode of payment (backport [#45591](#45591)) ([#45917](#45917)) ([e271a5c](e271a5c))
Bhavan23
pushed a commit
to aerele/erpnext
that referenced
this pull request
Feb 20, 2025
* fix: pos accounting dimension fieldname error * fix: method to get enabled accounting dimensions * fix: fetch enabled accounting dimensions * fix: clear flags for accounting_dimensions_details on_update * refactor: validation for doctype * fix: using get_checks_for_pl_and_bs_accounts for accounting dimensions
0xD0M1M0
pushed a commit
to 0xD0M1M0/erpnext
that referenced
this pull request
Feb 21, 2025
…frappe#45921) * fix: pos accounting dimension fieldname error (frappe#45899) * fix: pos accounting dimension fieldname error * fix: method to get enabled accounting dimensions * fix: fetch enabled accounting dimensions * fix: clear flags for accounting_dimensions_details on_update * refactor: validation for doctype * fix: using get_checks_for_pl_and_bs_accounts for accounting dimensions (cherry picked from commit 60a5f4f) # Conflicts: # erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.py * chore: resolve conflict * chore: resolve linter issue * fix: resolve linter issue * chore: resolve linter issue * chore: resolve linter issue * chore: resolve linter issue --------- Co-authored-by: Diptanil Saha <diptanil@frappe.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed support ticket
During POS Invoice Consolidation, non-mandatory accounting dimensions were not being set.
Also replaced scrubbing and unscrubbing accounting dimension label with exact accounting dimension fieldname.