Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get accounting dimension by document_type #45683

Closed
wants to merge 1 commit into from
Closed

fix: get accounting dimension by document_type #45683

wants to merge 1 commit into from

Conversation

venkat102
Copy link
Contributor

Issue:
unable to save pos-profile, when the accounting dimension is created in a different name than the doctype name and made it mandatory
ref: 30597

Accounting Dimension:
image

POS-Profile:
image

Issue:
image

backport needed for v15

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 3, 2025
@ruthra-kumar ruthra-kumar self-assigned this Feb 18, 2025
@ruthra-kumar ruthra-kumar self-requested a review February 18, 2025 03:40
@ruthra-kumar
Copy link
Member

ruthra-kumar commented Feb 18, 2025 •
edited
Loading

@venkat102

required_accounting_dimensions method was removed in #45899. But issue still persists on develop. Can you redo your fix on latest develop?

@venkat102
Copy link
Contributor Author

@ruthra-kumar
created a revised PR #45974

@venkat102 venkat102 closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruthra-kumar ruthra-kumar ruthra-kumar approved these changes

Assignees

@ruthra-kumar ruthra-kumar

Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venkat102 @ruthra-kumar