Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove override to set item tax based on HSN code #34739

Merged
merged 1 commit into from
Apr 7, 2023
Merged

chore!: remove override to set item tax based on HSN code #34739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions erpnext/stock/doctype/item/item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ def validate(self):
self.validate_auto_reorder_enabled_in_stock_settings()
self.cant_change()
self.validate_item_tax_net_rate_range()
set_item_tax_from_hsn_code(self)

if not self.is_new():
self.old_item_group = frappe.db.get_value(self.doctype, self.name, "item_group")
Expand Down Expand Up @@ -1316,11 +1315,6 @@ def update_variants(variants, template, publish_progress=True):
frappe.publish_progress(count / total * 100, title=_("Updating Variants..."))


@erpnext.allow_regional
def set_item_tax_from_hsn_code(item):
pass


def validate_item_default_company_links(item_defaults: List[ItemDefault]) -> None:
for item_default in item_defaults:
for doctype, field in [
Expand Down