Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove override to set item tax based on HSN code #34739

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

sagarvora
Copy link
Collaborator

@sagarvora sagarvora commented Apr 4, 2023

We are now using the doc_events hook in India Compliance instead (resilient-tech/india-compliance#556)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 4, 2023
@sagarvora sagarvora added do not backport defer backport and removed needs-tests This PR needs automated unit-tests. do not backport labels Apr 4, 2023
@sagarvora
Copy link
Collaborator Author

This PR can be optionally backported a bit later to avoid inconsistencies with older versions of India Compliance.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #34739 (9c66ebb) into develop (12325cb) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34739   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          810      810           
  Lines        59662    59658    -4     
========================================
- Hits         38086    38084    -2     
+ Misses       21576    21574    -2     
Impacted Files Coverage Δ
erpnext/stock/doctype/item/item.py 85.66% <ø> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

@s-aga-r s-aga-r merged commit ba553db into frappe:develop Apr 7, 2023
@sagarvora sagarvora deleted the item-tax-override-remove branch April 7, 2023 18:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants