Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: QR Code multi currency issue (backport #32086) #32088

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2022

This is an automatic backport of pull request #32086 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

When try to scan qr code on app it is showing correct values for multi currencies because it is not getting base amount

(cherry picked from commit b10a2b8)
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #32088 (d14a9a1) into version-14-hotfix (6976316) will increase coverage by 0.14%.
The diff coverage is 0.00%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-14-hotfix   #32088      +/-   ##
=====================================================
+ Coverage              63.15%   63.30%   +0.14%     
=====================================================
  Files                    813      813              
  Lines                  57613    57613              
=====================================================
+ Hits                   36387    36471      +84     
+ Misses                 21226    21142      -84     
Impacted Files Coverage Δ
erpnext/regional/saudi_arabia/utils.py 23.07% <0.00%> (ø)
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 70.65% <0.00%> (-4.35%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 65.67% <0.00%> (-2.71%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 76.87% <0.00%> (-0.69%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.11% <0.00%> (-0.44%) ⬇️
...xt/e_commerce/doctype/website_item/website_item.py 48.36% <0.00%> (-0.41%) ⬇️
...t/accounts/report/general_ledger/general_ledger.py 67.23% <0.00%> (-0.35%) ⬇️
...ext/manufacturing/doctype/work_order/work_order.py 78.16% <0.00%> (-0.15%) ⬇️
... and 20 more

@deepeshgarg007 deepeshgarg007 merged commit 354aaae into version-14-hotfix Sep 7, 2022
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-32086 branch September 13, 2022 12:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants