Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: QR Code multi currency issue #32086

Conversation

hamzaali15
Copy link

When try to scan qr code on app it is showing correct values for multi currencies because it is not getting base amount
image
image
As above images showing:

  1. Grand Total is 105 in USD and 394.60 in SAR
  2. Tax Amount is 5 in USD and 18.79 in SAR

whereas when try to scan QR code of invoice it is not fetching the base amount but using base currency symbol
image
Before changing in the code this QR code is showing Invoice Total: 105 SAR & VAT Total: 5 SAR while it should show 105 USD or 394.60 SAR
image
After amend the code it is showing 394.60 SAR insted of 105 USD which is correct

When try to scan qr code on app it is showing correct values for multi currencies because it is not getting base amount
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix develop

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2022

backport version-14-hotfix develop

✅ Backports have been created

@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

deepeshgarg007 added a commit that referenced this pull request Sep 7, 2022
…-32086

fix: QR Code multi currency issue (backport #32086)
deepeshgarg007 added a commit that referenced this pull request Sep 7, 2022
fix: QR Code multi currency issue (backport #32086)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants