Add validation when paying excess amount #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt for an invoice
…played-while-paying-excess-amount Added validation to give error message when trying to pay excess amount for an invoice
18alantom
reviewed
Nov 1, 2021
models/doctype/Payment/Payment.js
Outdated
Comment on lines
112
to
114
| throw new frappe.errors.ValidationError( | ||
| `Payment amount ${value} cannot be accepted. Please enter a value between 0 and ${amount}` | ||
| ); |
There was a problem hiding this comment.
@piyushsinghania on checking the change, it doesn't allow me to set a value greater than what is expected:
Screen.Recording.2021-11-01.at.10.55.45.mov
So keeping that in mind I suggest a few changes:
- Reword the message to something like "Payment amount cannot exceed ₹ ${amount}." , or you can reword it to also account for the fact that the value has been reset to the max viable amount (in haste they may not notice this, and later on it can be an issue).
- And "Payment amount cannot be ₹ 0.00" in case the amount is 0.
- Don't forget the currency sigil. For this, we could use a helper function to format currencies to the correct precision with the correct sigil.
- Don't forget to wrap the message in
frappe._to support translations later when we add them.
Other than that it works perfectly, I think capping it to the max viable amount is a nice touch!
(cc: @ankitsinghaniyaz)
There was a problem hiding this comment.
#1 we'll verify and 100% on the other points.
…played-while-paying-excess-amount Added translation support and currency symbol in the error message
|
@18alantom addressed all the feedback |
ankitsinghaniyaz
commented
Nov 1, 2021
|
Didn't realize the capping was auto 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.