Added validation to give error message when trying to pay excess amount for an invoice #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt for an invoice
ankitsinghaniyaz
requested changes
Oct 29, 2021
models/doctype/Payment/Payment.js
Outdated
| formula: doc => doc.getSum('for', 'amount'), | ||
| validate(value, doc) { | ||
| let amount = doc.getSum('for', 'amount'); | ||
| let isValid = amount >= value && value > 0 ? true : false; |
There was a problem hiding this comment.
Suggested change
| let isValid = amount >= value && value > 0 ? true : false; | |
| const isValid = amount >= value && value > 0 |
There was a problem hiding this comment.
Also lean on using const unless you can't. Then use let
models/doctype/Payment/Payment.js
Outdated
| let isValid = amount >= value && value > 0 ? true : false; | ||
|
|
||
| if (!isValid) { | ||
| throw new frappe.errors.ValidationError(`Invalid amount ${value}`); |
There was a problem hiding this comment.
Suggested change
| throw new frappe.errors.ValidationError(`Invalid amount ${value}`); | |
| throw new frappe.errors.ValidationError(`Payment amount ${value} cannot be accepted. Please enter a value between 0 and ${amount}`); |
|
@ankitsinghaniyaz updated as per the suggested changes. |
ankitsinghaniyaz
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ankitsinghaniyaz added validation to give an error message when trying to pay the excess amount for an invoice or a negative amount.