fix(install): Replace platform.dist with distro.linux_distribution for PY3.8+ compatibility

.travis.yml

@@ -58,17 +58,17 @@ matrix:
   - name: "Python 3.6 Easy Install"
     python: 3.6
     env: TEST=easy_install
-    script: sudo python $TRAVIS_BUILD_DIR/install.py --user travis --run-travis --production --verbose
+    script: sudo -H python3 $TRAVIS_BUILD_DIR/install.py --user travis --run-travis --production --verbose
 
   - name: "Python 3.7 Easy Install"
     python: 3.7
     env: TEST=easy_install
-    script: sudo python $TRAVIS_BUILD_DIR/install.py --user travis --run-travis --production --verbose
+    script: sudo -H python3 $TRAVIS_BUILD_DIR/install.py --user travis --run-travis --production --verbose
 
   - name: "Python 3.8 Easy Install"
     python: 3.8
     env: TEST=easy_install
-    script: sudo python $TRAVIS_BUILD_DIR/install.py --user travis --run-travis --production --verbose
+    script: sudo -H python3 $TRAVIS_BUILD_DIR/install.py --user travis --run-travis --production --verbose
 
 install:
   - pip install urllib3 pyOpenSSL ndg-httpsclient pyasn1

install.py

@@ -10,6 +10,7 @@
 import platform
 import warnings
 import datetime
+import importlib
 
 
 tmp_bench_repo = os.path.join('/', 'tmp', '.bench')
@@ -20,7 +21,8 @@
 log_file_name = "easy-install__{0}__{1}.log".format(execution_day, execution_time.replace(':', '-'))
 log_path = os.path.join(tmp_log_folder, log_file_name)
 log_stream = sys.stdout
-
+PY2 = sys.version_info.major == 2
+PY3 = not PY2
 
 def log(message, level=0):
 	levels = {
@@ -34,6 +36,16 @@ def log(message, level=0):
 	print(start + message + end)
 
 
+def import_python_package(package):
+	try:
+		importlib.import_module(package)
+	except ImportError:
+		log("Installing {0}".format(package))
+		subprocess.check_call([sys.executable, "-m", "pip", "install", package])
+	finally:
+		globals()[package] = importlib.import_module(package)
+
+
 def setup_log_stream(args):
 	global log_stream
 	sys.stderr = sys.stdout
@@ -78,7 +90,7 @@ def check_distribution_compatibility():
 	dist_name, dist_version = get_distribution_info()
 	supported_dists = {
 		'macos': [10.9, 10.10, 10.11, 10.12],
-		'ubuntu': [14, 15, 16, 18, 19],
+		'ubuntu': [14, 15, 16, 18, 19, 20],
 		'debian': [8, 9],
 		'centos': [7]
 	}
@@ -96,13 +108,12 @@ def check_distribution_compatibility():
 
 def get_distribution_info():
 	# return distribution name and major version
-	if platform.system() == "Linux":
-		current_dist = platform.dist()
-		return current_dist[0].lower(), current_dist[1].rsplit('.')[0]
+	if platform.system() == 'Linux':
+		return (distro.id(), distro.major_version())
 
-	elif platform.system() == "Darwin":
+	elif platform.system() == 'Darwin':
 		current_dist = platform.mac_ver()
-		return "macos", current_dist[0].rsplit('.', 1)[0]
+		return ('macos', current_dist[0].rsplit('.', 1)[0])
 
 
 def run_os_command(command_map):
@@ -125,7 +136,6 @@ def install_prerequisites():
 	# pre-requisites for bench repo cloning
 	run_os_command({
 		'apt-get': [
-			'sudo apt-get update',
 			'sudo apt-get install -y git build-essential python3-setuptools python3-dev libffi-dev'
 		],
 		'yum': [
@@ -137,7 +147,6 @@ def install_prerequisites():
 	install_package('curl')
 	install_package('wget')
 	install_package('git')
-	install_package('pip3', 'python3-pip')
 
 	success = run_os_command({
 		'python3': "sudo -H python3 -m pip install --upgrade setuptools cryptography ansible==2.8.5 pip"
@@ -172,6 +181,17 @@ def install_package(package, package_name=None):
 		could_not_install(package)
 
 
+def install_pip():
+	run_os_command({
+		'apt-get': 'sudo apt-get update',
+		'yum': 'sudo yum check-update'
+	})
+	if PY3:
+		install_package('pip3', 'python3-pip')
+	else:
+		install_package('pip2', 'python-pip')
+
+
 def install_bench(args):
 	# clone bench repo
 	if not args.run_travis:
@@ -408,7 +428,7 @@ def parse_commandline_args():
 	return args
 
 if __name__ == '__main__':
-	if sys.version[0] == '2':
+	if PY2:
 		if not os.environ.get('CI'):
 			if not raw_input("It is recommended to run this script with Python 3\nDo you still wish to continue? [Y/n]: ").lower() == "y":
 				sys.exit()
@@ -433,6 +453,11 @@ def parse_commandline_args():
 	with warnings.catch_warnings():
 		warnings.simplefilter("ignore")
 		setup_log_stream(args)
+		install_pip()
+		# this could break if pip isnt installed with python to begin with
+		# specifically on Python 2 <=2.7.9 or Python 3 <=3.4
+		# refs: https://pip.pypa.io/en/stable/installing/#do-i-need-to-install-pip
+		import_python_package('distro')
 		check_distribution_compatibility()
 		check_system_package_managers()
 		check_environment()