-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install): Replace platform.dist with distro.linux_distribution for PY3.8+ compatibility #1017
Conversation
Replace platform.dist() with distro.linux_distribution in install.py | platform.dist() not supported by python3.8 istro Information (Required) Ubuntu 20.04 LTS And for all new distros in future Possible Solution To replace Replace platform.dist() with distro.linux_distribution in install.py Use this module https://github.com/nir0s/distro for getting distro/system verion information. I will try to cook something myself. But I am not a professional programmer. So if anybody can work on this request.
The do think now the failure is coming from other dependencies...? |
Co-authored-by: Rohan <Alchez@users.noreply.github.com>
Co-authored-by: Rohan <Alchez@users.noreply.github.com>
Changed current_dist = platfor.dist() TO current_dist = platform.dist()
…sion of python version File "/home/travis/build/frappe/bench/install.py", line 89, in check_distribution_compatibility dist_name, dist_version = get_distribution_info() TypeError: 'NoneType' object is not iterable
Co-authored-by: Rohan <Alchez@users.noreply.github.com>
Co-authored-by: gavin <gavin18d@gmail.com>
Anybody has any idea why import module distro error ? Traceback (most recent call last):
Normally this should not cause this error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation and new lines!
Co-authored-by: gavin <gavin18d@gmail.com>
Hi guys it seems all checks are passed. Let me know if you need any more changes.. |
@nikunj1222 sorry we couldn't get this fixed earlier. but #1048 has been merged. Thanks for your contribution. |
Replace platform.dist() with distro.linux_distribution in install.py | platform.dist() not supported by python3.8
Distro Information (Required)
Python >= 3.5
Ubuntu 20.04 LTS
And for all new distros in future
Possible Solution
To replace Replace platform.dist() with distro.linux_distribution in install.py
Use this module https://github.com/nir0s/distro for getting distro/system verion information.
Install distro module
`
Sudo pip install distro
`